Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScriptCache: Clear abandoned parser refs #94678

Merged
merged 1 commit into from
Jul 24, 2024
Merged

GDScriptCache: Clear abandoned parser refs #94678

merged 1 commit into from
Jul 24, 2024

Conversation

rune-scape
Copy link
Contributor

regression from #90601

keeps track of GDScriptParserRefs that have been removed from the cache and clears them in all the same places as the true parser refs

avoids leaking these GDScriptParserRefs when they have cyclic refs to each other

@rune-scape rune-scape requested a review from a team as a code owner July 23, 2024 20:10
@dalexeev dalexeev added this to the 4.3 milestone Jul 23, 2024
akien-mga
akien-mga approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no GDScript expert but it looks simple enough, and as it's a regression fix I'd like it included in the imminent 4.3 RC 1 build.

Post-merge review from the GDScript team would still be welcome.

@akien-mga akien-mga merged commit 022d702 into godotengine:master Jul 24, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@rune-scape rune-scape deleted the clear-abandoned-parser-refs branch July 29, 2024 00:15
@dalexeev dalexeev mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@rune-scape @akien-mga @dalexeev